How to do a code review (google.github.io)

Article summary

The article provides guidelines on how to do a code review, based on Google's engineering practices. It covers topics such as the standard of code review, what to look for, and how to write code review comments. The guidelines are intended to be helpful to individuals and teams, and are presented as a series of separate sections. The article also references other related resources, including the CL Author's Guide.

Main themes

• code review
• engineering practices
• version control
• Google's development process
• open-source projects

What commenters say

• The term 'CL' is not clearly defined in the article and may be confusing for some readers.
• Google's use of 'CL' is similar to other version control systems, such as GitHub's 'pull request' or Gitlab's 'merge request'.
• The article's guidelines are too verbose and unintuitive, and could be improved with the use of bullet points and figures.
• Google's open-source process and IARC program are unusually accommodating and allow employees to work on personal projects, but may still be subject to certain restrictions and guidelines.
• The concept of '20% time' is still available at Google, but its implementation and usage may vary.
• The ownership of code written by Google employees is not always clear-cut, and may depend on various factors such as the use of company resources or the project's relation to Google's business.
• The article's emphasis on incremental and steady development, as well as the importance of considering the long-term health of the code, is a key aspect of effective code review.